This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.7][google] Adding a new option "-fstack-protector-strong". (issue 5461043)
- From: davidxl at google dot com
- To: shenhan at google dot com, pinskia at gmail dot com, richard dot guenther at gmail dot com, dnovillo at google dot com, jakub at redhat dot com, xur at google dot com
- Cc: gcc-patches at gcc dot gnu dot org, davidxi at google dot com, reply at codereview-hr dot appspotmail dot com
- Date: Tue, 24 Jan 2012 22:16:22 +0000
- Subject: Re: [4.7][google] Adding a new option "-fstack-protector-strong". (issue 5461043)
- Reply-to: shenhan at google dot com, pinskia at gmail dot com, richard dot guenther at gmail dot com, dnovillo at google dot com, jakub at redhat dot com, xur at google dot com, davidxl at google dot com, gcc-patches at gcc dot gnu dot org, davidxi at google dot com, reply at codereview-hr dot appspotmail dot com
Also need to update doc/invoke.texi file for the new option.
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c
File gcc/cfgexpand.c (right):
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1531
gcc/cfgexpand.c:1531: record_or_union_type_has_array (const_tree
tree_type)
Better add '_p' suffix to the predicate function name.
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1535
gcc/cfgexpand.c:1535: for (f = fields; f; f = DECL_CHAIN (f))
Add an empty line after declarations.
http://codereview.appspot.com/5461043/diff/16001/gcc/cfgexpand.c#newcode1702
gcc/cfgexpand.c:1702: if (flag_stack_protect == 2
Add more descriptions. Better yet, fix the flag value mapping --
protect_all-> 3, protect --> 2, and protect_strong-->1
http://codereview.appspot.com/5461043/