Re: Fix checks for !TARGET_MACHO

[Iain Sandoe <developer at sandoe-acoustics dot co dot uk>]

On 18 Jan 2012, at 12:26, Gerald Pfeifer wrote:

> On Tue, 17 Jan 2012, Tijl Coosemans wrote:
> > TARGET_MACHO is always defined (either 0 or 1) so using #ifndef to  
> > test
> > for !TARGET_MACHO is incorrect. Introduced here:
> > http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00623.html
> >
> > The i386 case has been tested on i386-freebsd. The compiler now emits
> > calls to __stack_chk_fail_local again when using -fstack-protector - 
> > fpic.
> >
> > The rs6000 cases are untested.

I'll try and fit a test in, in the next couple of days, my ppc machine  
is in a test-cycle at the moment.

equally important is to test that it doesn't mess up anything else -  
which could be done by building a cross -> powerpc-unknown-linux?

> > I don't have commit access, so please commit when approved.
> >
> >
> > 2011-01-10  Tijl Coosemans  <tijl@coosemans.org>
> >
> > 	* config/i386/i386.c: Fix checks for !TARGET_MACHO.
> > 	* config/rs6000/rs6000.c: Likewise.
>
> Reviewers, I volunteer to commit when/if approved.  (This fixes an
> issue I care about. :-)

it looks reasonable to me, but I am not able to approve (or reject) it.

Iain