Re: [committed] Adjust ssa-dom-thread-4.c for MIPS

[Andrew Pinski <pinskia at gmail dot com>]

On Sun, Jan 15, 2012 at 10:45 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Sun, Jan 15, 2012 at 10:31 AM, Richard Sandiford
> <rdsandiford@googlemail.com> wrote:
>> ssa-dom-thread-4.c was failing for MIPS because the mips.h definition:
>>
>> #define LOGICAL_OP_NON_SHORT_CIRCUIT 0
>>
>> caused "var1 || var2" conditions to be split into two rather than
>> converted into "(var1 != 0) | (var2 != 0)". ÂI don't know whether
>> the MIPS definition still makes sense (probably not for Octeon2
>> at least) but it's too late to change it for this release.
>
> For non floating point types it does not make sense (but then again
> Octeon2 does not have implement floating point instructions).

I mean it makes sense for non floating point types.  For floating
point comparisons we should not combine at all.  I am working on a
patch for 4.8 to do that.

Thanks,
Andrew Pinski