This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,testsuite]: Fix testcase that bangs long and int against void*
On Jan 13, 2012, at 9:23 AM, Rainer Orth wrote:
> Mike Stump <mikestump@comcast.net> writes:
>
>> On Jan 13, 2012, at 4:33 AM, Georg-Johann Lay wrote:
>>> This test case is obviously written for 32-bit platforms, thus added
>>> "dg-require-effective-target ilp32" to ensure that the pointer mess won't lead
>>> to FAILs because of
>>>
>>> warning: cast to pointer from integer of different size
>>>
>>> and
>>>
>>> warning: cast from pointer to integer of different size
>>>
>>> Ok to apply?
>>
>> Ok.
>>
>>> * gcc.dg/lto/20091013-1_0.c: Add dg-require-effective-target ilp32.
>
> I wonder if the fix is right, though: the testcase currenly passes for
> 64-bit multilibs, but won't run there any longer if the patch is
> applied.
I rely upon words like obviously written for 32-bit platforms a little too much apparently, sorry. I agree, let's find some other solution. I've starred at the code, and is was not clear to me why you thought it was obviously for 32-bit platforms.
So, I'd propose the -Wno- option silence the warning... Seem reasonable to people, if so, Ok.