This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, Fortran] Fix PR 49693, unused variable warnings in common blocks
- From: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 4 Jan 2012 10:05:02 +0100
- Subject: Re: [patch, Fortran] Fix PR 49693, unused variable warnings in common blocks
Thomas Koenig wrote:
> the attached patch fixes the PR by unconditionally disabling warnings
> about unused variables in common blocks.
I was wondering whether it disables intended diagnostic. However, I think
setting TREE_USED () is OK. Common-related diagnostic is better done by the
front end (via attr.referenced) - such as for '"a" explicitly use-associated
but not used'.
> Regression-tested. OK for trunk?
OK. Thanks for the patch.
Tobias
PS: If I have not missed anything, the current patch review/committal status is:
Reviewed but not committed:
- This patch ;-)
- Mikael's scalarizer patch for OPTIONAL + ELEMENTAL
http://gcc.gnu.org/ml/fortran/2012-01/msg00005.html
Unreviewed:
- Rainer's [libgfortran, libitm] Link with -shared-libgcc
http://gcc.gnu.org/ml/fortran/2011-12/msg00117.html
- My Deregister allocatable COARRAYS, fixes to (de)allocate
http://gcc.gnu.org/ml/fortran/2011-12/msg00157.html
- Paul's PR48946 - Deferred Overloaded Assignment
(half reviewed) http://gcc.gnu.org/ml/fortran/2012-01/msg00026.html