This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR48946 - Deferred Overloaded Assignment


Hi Paul,

Dear All,

This is a straightforward patch that adds a last ditch attempt to find
a specific typebound procedure when all that has been found for a
derived type base object is 'deferred'.  typebound_operator_7.f03 has
been extended to test derived type as well as class base objects.

Bootstrapped and regtested on x86_64/FC9 - OK for trunk?

I am not really familiar with the OOP stuff, but this looks OK for me. Just one nit:


2012-01-03 Paul Thomas<pault@gcc.gnu.org>

	PR fortran/PR48946
	* gfortran.dg/typebound_operator_7.f03: Add test for derived
	type typebound operators as well as class bound operators.

Wouldn't it be better to make a new test case? If there turns out to be a regression later, changing test cases makes it harder to find.

You could just commit the test case 'as is' as typebound_operator_8.f03
and leave the old one.

Regards

Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]