This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, SMS] Prevent the creation of reg-moves for definitions with MODE_CC

From: Revital Eres <revital dot eres at linaro dot org>
To: Ayal Zaks <ayal dot zaks at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Patch Tracking <patches at linaro dot org>, richard dot sandiford at linaro dot org, Richard Henderson <rth at redhat dot com>
Date: Sun, 1 Jan 2012 15:51:44 +0200
Subject: Re: [PATCH, SMS] Prevent the creation of reg-moves for definitions with MODE_CC
References: <CAHz1=dWh6nP9kDj8SnSRqz970z+ikV=5f3Yb5syL6h00im_FrA@mail.gmail.com> <g4aa6ni195.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com> <4EF2377A.3080205@redhat.com> <g4ty4tgf7j.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com> <CAHTt4Ks=bGFPr5s+h9i+W9qC-X0NRrxKX=ZbYek=uHkmpaXTFg@mail.gmail.com>

Hello,

> Yes, thanks for catching this. Shouldn't we prevent creating such
> regmoves for (the other case of) intra-loop anti-deps as well?

Right! sorry for missing that. I added an additional check in
create_ddg_dep_from_intra_loop_link.

Also, thanks to Bernhard Rosenkraenzer for opening PR 879725 for that
ICE in Linaro GCC DB.

Currently re-testing the patch on ppc64-redhat-linux and will commit
it once testing completes if that's OK .

Thanks,
Revital

gcc/
        * ddg.c (def_has_ccmode_p): New function.
        (add_cross_iteration_register_deps,
        create_ddg_dep_from_intra_loop_link): Call it.

testsuite/
        * gcc.dg/sms-11.c: New file.

Attachment: patch_allocatable_1_12.txt
Description: Text document

References:
- Re: [PATCH, SMS] Prevent the creation of reg-moves for definitions with MODE_CC
  - From: Ayal Zaks

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]