This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Avoid leading dash in expr call
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: gcc-patches at gcc dot gnu dot org
- Date: Tue, 20 Dec 2011 17:55:20 +0100
- Subject: Avoid leading dash in expr call
- References: <m2ehw29ieh.fsf@igel.home>
Andreas Tobler pointed out that passing a string with leading dash as
argument to expr is non-portable. Checked in as obvious.
Andreas.
2011-12-20 Andreas Schwab <schwab@linux-m68k.org>
* warnings.m4 (ACX_PROG_CC_WARNING_OPTS): Avoid leading dash in
expr call.
diff --git a/config/warnings.m4 b/config/warnings.m4
index 292e5a4..b64b594 100644
--- a/config/warnings.m4
+++ b/config/warnings.m4
@@ -32,7 +32,7 @@ for real_option in $1; do
# Do the check with the no- prefix removed since gcc silently
# accepts any -Wno-* option on purpose
case $real_option in
- -Wno-*) option=-W`expr $real_option : '-Wno-\(.*\)'` ;;
+ -Wno-*) option=-W`expr x$real_option : 'x-Wno-\(.*\)'` ;;
*) option=$real_option ;;
esac
AS_VAR_PUSHDEF([acx_Woption], [acx_cv_prog_cc_warning_$option])
--
1.7.8
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."