This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch testsuite g++.dg]: Reflect ABI change for windows native targets about bitfield layout in structures


2011/12/15 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
> Kai Tietz <ktietz70@googlemail.com> writes:
>
>> Index: g++.dg/abi/bitfield3.C
>> ===================================================================
>> --- g++.dg/abi/bitfield3.C ? ?(revision 182092)
>> +++ g++.dg/abi/bitfield3.C ? ?(working copy)
>> @@ -3,7 +3,7 @@
>> ?// { dg-options "-O2" }
>> ?// Cygwin and mingw32 default to MASK_ALIGN_DOUBLE. Override to ensure
>> ?// 4-byte alignment.
>> -// { dg-options "-mno-align-double" { target i?86-*-cygwin* i?86-*-mingw* } }
>> +// { dg-options "-mno-align-double -mno-ms-bitfields" { target
>> i?86-*-cygwin* i?86-*-mingw* } }
>
> The comment only explains the -mno-align-double now. ?Would you please
> add an explanation for -mno-ms-bitfields, too?
>
> Thanks.
> ? ? ? ?Rainer

Fine, so patch looks now like that.

Kai

Index: bitfield3.C
===================================================================
--- bitfield3.C (revision 182092)
+++ bitfield3.C (working copy)
@@ -1,9 +1,11 @@
 // Test for oversized bitfield alignment in structs on IA-32
 // { dg-do run { target { { i?86-*-* x86_64-*-* } && ia32 } } }
 // { dg-options "-O2" }
-// Cygwin and mingw32 default to MASK_ALIGN_DOUBLE. Override to ensure
+// Cygwin and mingw default to MASK_ALIGN_DOUBLE. Override to ensure
 // 4-byte alignment.
-// { dg-options "-mno-align-double" { target i?86-*-cygwin* i?86-*-mingw* } }
+// As for mingw target the the ms-bitfield switch is activated by default,
+// make sure for this test that it is disabled.
+// { dg-options "-mno-align-double -mno-ms-bitfields" { target i?86-*-cygwin* i
?86-*-mingw* } }

 struct A
 {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]