This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR bootstrap/51479: Missing dependency on errors.o causes bootstrap failure


On Fri, 9 Dec 2011, Richard Guenther wrote:

> On Fri, Dec 9, 2011 at 7:17 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> > gcc/Makefile.in has
> >
> > gengtype$(exeext) : gengtype.o gengtype-lex.o gengtype-parse.o \
> > ? ? ? ? ? ? ?gengtype-state.o version.o errors.o $(LIBDEPS)
> > ? ? ? ?+$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ \
> > ? ? ? ? ? ?$(filter-out ($LIBDEPS), $^) $(LIBS)
> >
> > However, there is no errors.o dependency, which leads to random
> > parallel build failures. ?This patch adds errors.o dependency. ?OK
> > for trunk and release branches?
> 
> Ok. (the 4.5 and 4.6 branches already have dependencies for error.o,
> did they get lost somehow? Consider placing the error.o dependency
> at the same old place to ease diffs)

errors.c ceased to be used for the host with my

2011-05-20  Joseph Myers  <joseph@codesourcery.com>

        * Makefile.in (LIBDEPS): Add libcommon.a.
[...]

patch that made installed host programs consistently use the common 
diagnostics infrastructure.  So that patch removed the dependencies.  It 
appears that

2011-08-04  Romain Geissler  <romain.geissler@gmail.com>

        * gengtype-state.c: Include "bconfig.h" if
[...]

then reintroduced use of errors.o on the host by making gengtype an 
installed program.

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]