Re: [PATCH] Fix PR middle-end/39976, 200.sixtrack degradation

[Richard Guenther <richard dot guenther at gmail dot com>]

On Mon, Dec 5, 2011 at 3:52 PM, William J. Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
>
>
> On Mon, 2011-12-05 at 08:36 -0600, William J. Schmidt wrote:
>>
>> On Mon, 2011-12-05 at 14:59 +0100, Michael Matz wrote:
>> > Hi,
>> >
>> > On Fri, 2 Dec 2011, William J. Schmidt wrote:
>> >
>> > > > on top of your current version. ?That ought to remove the added PHI
>> > > > expressions (and only them) from the hash table but retain the
>> > > > information of equality in the const_or_copies_stack. ?Checking the BB
>> > > > wouldn't be required then.
>> > >
>> > > Bootstrapped and regression tested on powerpc64-linux.
>> >
>> > Another nit (sorry I didn't see this before :-/) :
>> >
>> > > + ? ? ?expr->ops.phi.args = (tree *) xcalloc (nargs, sizeof (tree));
>> >
>> > This leaks, because you missed to add freeing to free_expr_hash_elt.
>> > Apart from that looks good to me, but I can't approve.
>> >
>>
>> /facered :(
>>
>> Thanks. ?Will fix...
>>
>> Bill
>
> Richard -- OK with this change?

Yes.

Thanks,
Richard.

>>
>> >
>> > Ciao,
>> > Michael.
>> >
>