This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: empty range in pop_heap

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: Markus Trippelsdorf <markus at trippelsdorf dot de>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sun, 4 Dec 2011 13:31:14 +0000
Subject: Re: empty range in pop_heap
References: <20111112135324.GA23388@x4.trippels.de> <alpine.DEB.2.02.1111121500550.2466@laptop-mg.saclay.inria.fr> <20111112141241.GB23388@x4.trippels.de> <CAH6eHdRBDutjk49ssY7HR4JgRLGAg1g8i2=Ag_o1=_8pV8ZMLA@mail.gmail.com> <alpine.DEB.2.02.1111121601470.2466@laptop-mg.saclay.inria.fr> <CAH6eHdQS6HSSx1e9pod6HuDavH=DTAnJCSwATXYMZ1t9BsM5eg@mail.gmail.com> <CAH6eHdRkVtpU24M9WVXk4afqkmhZXUs=JWyY5SHycXibMh2NEA@mail.gmail.com> <20111204093720.GA17045@x4.trippels.de>

On 4 December 2011 09:37, Markus Trippelsdorf wrote:
>
> You forgot to change the second one with the comparison functor.

Doh! Thanks, fixed now.

        * include/bits/stl_heap.h (pop_heap): Check for non-empty range in
        overload taking a predicate.
        * testsuite/25_algorithms/pop_heap/empty2_neg.cc: New.

Tested x86-64-linux, committed to trunk.

Attachment: pop_heap_pred.txt
Description: Text document

References:
- Re: empty range in pop_heap
  - From: Jonathan Wakely
- Re: empty range in pop_heap
  - From: Markus Trippelsdorf

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]