This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] xfail target-specific asms, & gcov


On Nov 27, 2011, at 3:41 PM, Nathan Sidwell <nathan@acm.org> wrote:
this patch extends scan-assembler (and scan-assembler-not) to allow something like:
/* { dg-final { scan-assembler "\\.hidden \t__gcov___ZN1X4FinkEv" { target { ! *-*-darwin* } } { xfail *-*- * } } } */

ok?

Almost... Every test that can fail, should be able to pass and every test that can pass, should be able to fail. The usual structure:


If (test fails)
  fail foo
else
  pass foo

Makes this trivially true. In your patch, you alter the spelling of a test, never do that. Once that is fixed, Ok.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]