This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ Patch] PR 51290

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Jason Merrill <jason at redhat dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Thu, 24 Nov 2011 11:24:15 +0100
Subject: Re: [C++ Patch] PR 51290
References: <4ECD995D.9080000@oracle.com> <4ECDB2D2.4070607@redhat.com>

On 11/24/2011 03:58 AM, Jason Merrill wrote:

On 11/23/2011 08:09 PM, Paolo Carlini wrote:
   if (null_test)
     {
-      tree zero = cp_convert (TREE_TYPE (expr), integer_zero_node);
+      tree zero = cp_convert (TREE_TYPE (expr),
+                  want_pointer ? nullptr_node : integer_zero_node);
This ?: is unnecessary; if null_test is true, so is want_pointer.

OK just using nullptr_node.

Thanks, yesterday was a bit tired and didn't noticed the trick with null_test set to error_mark_node a few lines before. Applied.

Paolo.

References:
- [C++ Patch] PR 51290
  - From: Paolo Carlini
- Re: [C++ Patch] PR 51290
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]