This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR 44707 testcase failure


Mike Stump wrote:
> On Nov 18, 2011, at 9:04 AM, "Ulrich Weigand" <uweigand@de.ibm.com> wrote:
> > Huh, it seems the test in this form assumes the assembler supports /* ...  */
> > comments.  But this isn't really necessary for the test to work; I think the
> > best fix would be to just remove the comment and simply write 20
> >   __asm__ volatile ("" : : "nro" (e1), "nro" (e2), "nro" (e3 ...
> > instead.
> 
> Sounds good to me.

OK, I've checked in the following patch.

Tested on i386-linux.

Bye,
Ulrich

ChangeLog:

	* gcc.c-torture/compile/pr44707.c: Do not assume assembler
	supports /* ... */ comments.

Index: gcc/testsuite/gcc.c-torture/compile/pr44707.c
===================================================================
--- gcc/testsuite/gcc.c-torture/compile/pr44707.c	(revision 181162)
+++ gcc/testsuite/gcc.c-torture/compile/pr44707.c	(working copy)
@@ -9,6 +9,6 @@
   int e3 = v.b;
   int e4 = v.c;
   int e5 = v.d;
-  __asm__ volatile ("/* %0 %1 %2 %3 %4 */" : : "nro" (e1), "nro" (e2), "nro" (e3), "nro" (e4), "nro" (e5));
+  __asm__ volatile ("" : : "nro" (e1), "nro" (e2), "nro" (e3), "nro" (e4), "nro" (e5));
 }
 

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]