This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Revert "PowerPC shrink-wrap support 3 of 3"
- From: Bernd Schmidt <bernds at codesourcery dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 14 Nov 2011 10:51:56 +0100
- Subject: Re: Revert "PowerPC shrink-wrap support 3 of 3"
- References: <201111111913.pABJDSVu017239@ignucius.se.axis.com>
On 11/11/11 20:13, Hans-Peter Nilsson wrote:
> AFAICT, your patch has got sufficiently testing now (on three
> targets to boot) to be considered safe to check in. Or is
> something amiss?
>
> (If it's the unchecked code quality you mentioned, that can be
> just as well dealt with having the tree in a working state;
> having the tree broken for some targets accomplishes nothing.)
I briefly looked at that, and while it does tend to move stuff around
compared to an unpatched compiler, the effects don't seem to be all that
bad. If we find a testcase where it's a real problem, we could do more
aggressive reordering after epilogue generation, when we no longer have
exit fallthroguh edges. So I'd like to ask for an OK here.
Bernd