This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran, patches] Two short patches to review
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: FX <fxcoudert at gmail dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 8 Nov 2011 15:34:26 -0800
- Subject: Re: [fortran, patches] Two short patches to review
- References: <F69C3B65-52E2-4164-8D97-6A961D836382@gmail.com>
On Wed, Nov 09, 2011 at 12:13:10AM +0100, FX wrote:
> PRs 50540 and 50404 each contain a short patch, written by Steve.
> Both patches are straightforward:
>
> -- 50404: refuse to have a CLOSE statement without a UNIT
> (F2008's C908 "A file-unit-number shall be specified in a
> close-spec-list") (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50404)
jerry already approved this one.
> -- 50540: issue a normal error instead of an internal error, in
> conditions that could reasonably be triggered by invalid code
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50540)
Given that you've read the patch and my comments in the PR,
and that you've contributed/reviewed/committed hundreds of
patches, I think that this is sufficient review. I certainly
have no problems with committing the patch.
PS: I would have committed these patch except I have spent a
week or so trying to get gcc to build again after I migrated my
systems to FreeBSD 10.0 (ie., the bleeding edge).
--
Steve