This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] define string::pop_back()
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 7 Nov 2011 09:20:17 +0000
- Subject: Re: [v3] define string::pop_back()
- References: <CAH6eHdS5iBXR-KZJRC1wx_TCTN2d2G721dCCu_JtXYG1RgjQZw@mail.gmail.com> <CAH6eHdREKVLJzuHa4e7vToxDwTtz0FP9Dibiq8ubgNLXGM2ocA@mail.gmail.com> <CAH6eHdSWO3Cq9LT6BnKfRYmQDQp=pyk-kBRqSvnJQFr34=UPGg@mail.gmail.com> <201111071017.10685.ebotcazou@adacore.com>
On 7 November 2011 09:17, Eric Botcazou wrote:
>> ? ? ? ? * include/bits/basic_string.h (basic_string::at): Move adjacent to
>> other overload.
>> ? ? ? ? (basic_string::pop_back): Define.
>> ? ? ? ? * include/debug/string (__gnu_debug::basic_string::pop_back):
>> Likewise. * include/ext/vstring.h (__versa_string::pop_back): Likewise. *
>> config/abi/pre/gnu.ver: Add new symbols.
>> ? ? ? ? * testsuite/21_strings/basic_string/modifiers/char/pop_back.cc:
>> New. * testsuite/21_strings/basic_string/modifiers/wchar_t/pop_back.cc:
>> New. * testsuite/21_strings/basic_string/range_access.cc: Split to ... *
>> testsuite/21_strings/basic_string/range_access/char/1.cc: Here and ... *
>> testsuite/21_strings/basic_string/range_access/wchar_t/1.cc: Here. *
>> testsuite/ext/vstring/modifiers/char/pop_back.cc: New.
>> ? ? ? ? * testsuite/ext/vstring/modifiers/wchar_t/pop_back.cc: New.
>
> This breaks bootstrap on Solaris:
>
> ld: fatal: libstdc++-symbols.ver-sun: 4806: symbol `std::basic_string<char,
> std::char_traits<char>, std::allocator<char> >::pop_back()' is already defined
> in file: libstdc++-symbols.ver-sun
>
> _ZNSs8pop_backEv is referenced twice in the version file.
Thanks, I'll try to work out the right adjustment for the solaris
symbols file but can't test it.