This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [build] Restore arm-eabi bootstrap (PR target/50978)
Paolo Bonzini <bonzini@gnu.org> writes:
>>> ./config/t-rtems:HOST_LIBGCC2_CFLAGS = -I$(srcdir)/../newlib/libc/sys/rtems/include
>
> This was LIBGCC2_INCLUDES before your patches.
>
> You're also missing it in many cases: arm, avr, bfin, moxie, h8300, lm32,
> m32r, m68k, mips, powerpc, sh, m32c.
Right, no idea why. I think it's best to set tmake_file=t-rtems for
*-*-rtems* and make sure all RTEMS targets only append to tmake_file.
>>> ./config/stormy16/t-stormy16:HOST_LIBGCC2_CFLAGS = -O2
>
> Seems unused to me, because this is not true anymore:
>
> tmake_file
> A list of machine-description-specific makefile-fragments,
> if different from "$cpu_type/t-$cpu_type".
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I think this wan't true ever, but has just been copied from config.gcc.
> Overall I suggest:
>
> * change t-rtems back to LIBGCC2_INCLUDES and add it for the missing
> targets;
Agreed: if LIBGCC2_INCLUDES had been dropped completely, that would
justify moving the -I flags to HOST_LIBGCC2_CFLAGS, but since other
targets still use it, there's no reason not to use it here, too.
> * change all to += except when a better course of action is suggested above.
>
> Of course unless you disagree with the analysis or had a reason for the
> t-rtems changes. :) Let's commit the two as separate patches.
Ok, but unless it's urgent, I'd like to go over it over the weekend and
commit on monday. I'm about to leave relatively soon.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University