This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Add Epiphany port


On Fri, 4 Nov 2011, Joern Rennecke wrote:

> :@item
> :Normally, one or more maintainers of that target listed in
> :@file{MAINTAINERS}.  Some existing architectures may be unmaintained,
> :but it would be unusual to add support for a target that does not have
> :a maintainer when support is added.
> :@end itemize
> 
> Doesn't this have to go through the Steering Commitee first?

Yes, all new port submissions should also have a separate message sent to 
the gcc@ list, for the attention of the SC, requesting the appointment of 
a maintainer (and proposing who that should be).

> +@item Cm1
> +A signed 11-bit constant added to -1

@minus{}1.  Likewise elsewhere.

> +Can only match when epiphany_m1reg is valid.

This doesn't make sense to me in the context of a user manual describing 
what can be used in inline asm.

> +Can only match when epiphany_m1reg is valid.

Likewise.

> +@item Csy
> +symbolic constant for call/jump instruction

Consistently start each of these items with a capital letter and end with 
".".

> +Constant suitable for the addsi3_r pattern.  This is a valid offset

"addsi3_r" also seems inappropriate for the user manual.

Any constraints not for use in asms can be put inside @ifset INTERNALS 
here - though really it's just those that can be used in asms that it's 
important to document here.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]