This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] 17/n: trans-mem: compiler trans-mem main engine
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 3 Nov 2011 20:38:09 +0000 (UTC)
- Subject: Re: [patch] 17/n: trans-mem: compiler trans-mem main engine
- References: <4EB2E6FC.5070901@redhat.com>
Make sure that you do need each #include present in this and any other new
file. Since 2008 a lot of includes of tm.h and toplev.h have been removed
and diagnostic-core.h introduced as an alternative to diagnostic.h for
many users. If tm.h is needed, it's good to have a comment on the
#include explaining why (which target macros are used, for example), since
we'd like to avoid unnecessary tm.h includes.
--
Joseph S. Myers
joseph@codesourcery.com