This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] 16/n: trans-mem: compiler parser/front-end
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 3 Nov 2011 20:34:58 +0000 (UTC)
- Subject: Re: [patch] 16/n: trans-mem: compiler parser/front-end
- References: <4EB2E588.1040806@redhat.com>
On Thu, 3 Nov 2011, Aldy Hernandez wrote:
> +/* Parse a transaction attribute (GCC Extension).
> +
> + transaction-attribute:
> + attributes
> + [ [ any-word ] ]
I don't see any syntax production comments including
transaction-attribute. Please update the comments to include this in
every case where it is permitted.
I take it that this is never used in a context where an expression might
occur, so you don't have problems with ambiguity? (One known issue with
the [[]] syntax is its interaction with ObjC/ObjC++ - it's always
unambiguous whether "[[" starts an attribute or an ObjC expression because
in the ObjC case the closing "]" and "]" won't be next to each other but
in the attribute case they will, but distinguishing the two requires an
indefinite amount of lookahead.)
--
Joseph S. Myers
joseph@codesourcery.com