This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] 6/n: trans-mem: runtime


On Thu, 3 Nov 2011, Aldy Hernandez wrote:

> Index: libitm/acinclude.m4
> ===================================================================
> --- libitm/acinclude.m4	(.../trunk)	(revision 0)
> +++ libitm/acinclude.m4	(.../branches/transactional-memory)	(revision
> 180773)
> @@ -0,0 +1,343 @@
> +dnl ----------------------------------------------------------------------
> +dnl This whole bit snagged from libgfortran.

If you need a configure test in more than one library, do not copy it like 
this; put a common macro in config/ and use it from both libraries.

> +dnl ----------------------------------------------------------------------
> +dnl This whole bit snagged from libstdc++-v3.

Likewise.  There may well be some bits that for whatever reason need to be 
similar but different, or that are specific to libitm, but if something 
can be shared then it should be shared.

> Index: libitm/Makefile.am
> ===================================================================
> --- libitm/Makefile.am	(.../trunk)	(revision 0)
> +++ libitm/Makefile.am	(.../branches/transactional-memory)	(revision
> 180773)

Do you need a FLAGS_TO_PASS setting as in 
<http://gcc.gnu.org/ml/gcc-patches/2011-09/msg01187.html>?  (The way to 
test is to do a multilib build and install, passing infodir=/some/where on 
the "make install" line, and see if the manual ends up installed in the 
configured directory under $prefix as well or instead of the directory 
passed on the "make install" line - it should only go in the directory 
passed to "make install".)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]