This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR50869] don't attempt to expand CFA within cselib
- From: Jeff Law <law at redhat dot com>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Oct 2011 12:09:25 -0600
- Subject: Re: [PR50869] don't attempt to expand CFA within cselib
- References: <orobx025bt.fsf@livre.localdomain>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/28/11 15:07, Alexandre Oliva wrote:
> An assertion check meant to verify that var loc expansions that
> didn't involve VALUEs (say constants, REGs, etc) didn't push values
> onto the dependency stack failed in an expansion of the argp reg,
> because equivalences for it are preserved at cselib table resets,
> and cselib later tries to expand it to equivalent expressions.
>
> It's not profitable to expand it within var-tracking, and that's
> the only user of the CFA-base special-casing in cselib, so I
> arranged for argp to be preserved in expansions, just like other
> stack base registers.
>
> While debugging it, I noticed it was theoretically possible for
> the expression depth to remain uninitialized, and added an
> initialization and an assertion check to make sure it only remains
> zero when no location is found.
>
> Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to
> install?
OK.
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJOruRVAAoJEBRtltQi2kC7JlIH/3zxv5lhZ2VaGGVFjntIZO2T
AlANqcP3UZRsbBcIQ4J/3MA19ob4QTw5gQq7nFxX1OGUlRag9mFzE00L3Q2uLCSn
z7OVZGNwL48eN5G36HH9UY5ktQmy14UPQfE1d4P+X3h/bhLAMHfaQuMIl2+/QK60
nhaGYQMx0qlv2Ndof+HNwo/6s/o4oX3bWS5EavPFyPCHuy7dGrlcY10C2gZnund8
JYA4byxtFKNybiji5WNFO2XxzjVCxGe0+XWAPqO2jNj3CBEfzMyUbZhVP3llOJBI
9Mcjn3k/kTp/3h9aGzoGPssYR9DpMxyU+IQlSPyhR9ZiNGCC7Udj/aALtI6/b/U=
=689Y
-----END PGP SIGNATURE-----