This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA:] fix breakage with "Update testsuite to run with slim LTO"



On 21 Oct 2011, at 10:31, Jan Hubicka wrote:


Date: Fri, 21 Oct 2011 00:19:32 +0200
From: Jan Hubicka <hubicka@ucw.cz>
Yes, if we scan assembler, we likely want -fno-fat-lto-objects.

then IIUC you need to patch *all* torture tests that use
scan-assembler and scan-assembler-not.  Alternatively, patch
somewhere else, like not passing it if certain directives are
used, like scan-assembler{,-not}.  And either way, is it safe to
add that option always, not just when also passing "-flto" or
something?

Hmm, some of assembler scans still works because they check for presence of symbols we output anyway, but indeed, it would make more sense to automatically imply -ffat-lto-object when scan-assembler is used. I am not sure if my dejagnu skill as on par here however.

Maybe you could make amends ;) by testing the following, which seems to work at least for dg-torture.exp and cris-elf/cris-sim, in which -ffat-lto-object is automatically added for each scan-assembler and scan-assembler-not test, extensible for other dg-final actions without polluting with checking LTO options and whatnot across the files. I checked (and corrected) so it also works when !check_effective_target_lto by commenting out the setting in the second chunk.

Thanks. It looks good to me. If we ever start scanning LTO assembler output,
we may simply add scan-lto-assembler variants or so...

It looks like the gnat testsuite is also broken - but HP's fix doesn't recover that.
.. will try and take a look - but short on time today,
Iain




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]