This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libiberty: fix psignal parameter type
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 18 Oct 2011 09:50:58 -0700
- Subject: Re: [PATCH] libiberty: fix psignal parameter type
- References: <x57jy5wi2qk8.fsf@frobland.mtv.corp.google.com>
On Tue, Oct 18, 2011 at 9:49 AM, Roland McGrath <mcgrathr@google.com> wrote:
> When libiberty defines psignal, it doesn't use the canonical signature.
> This came up as a problem in a configuration where libiberty wants to
> define psignal itself, but the build environment's <signal.h> declares
> it too.
>
> This was a --with-newlib configuration using the newlib trunk, where newlib
> does define psignal (and strsignal, among other things), but libiberty's
> configure thinks it knows exactly what newlib does and doesn't define
> without checking. ÂThis hard-coding seems unwise to me, exactly because of
> the potential for cases like this, where newlib's set of available
> functions changes over time.
libiberty is no longer compiled for the target so this should never
happen really.
Thanks,
Andrew Pinski