This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Vector shuffling
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: Artem Shinkarov <artyom dot shinkaroff at gmail dot com>, Richard Henderson <rth at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Duncan Sands <baldrick at free dot fr>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 6 Oct 2011 13:27:53 +0200
- Subject: Re: Vector shuffling
- References: <CABYV9SU02gncjg=AqMWTqJ-W=4GZM-x83RXiyQdPnVWyHSEgfQ@mail.gmail.com> <CABYV9SWmdR1crm=vLuGCCMZNWv7aESqVMscn=M4yeUP=W-AVHQ@mail.gmail.com> <CABYV9SU1KsFTvPfRjZpwH8joTPKJ6aFEWgwmy=_P9PrxFCKv=g@mail.gmail.com> <4E724C78.6020006@redhat.com> <CABYV9SV5kHMxRK5g3XRhVDysG=Nu-Szb_oOOsaMSudXXP0K8xg@mail.gmail.com> <4E83332D.1010002@redhat.com> <CABYV9SX+SDBg9JK7k25n7XAmcRQ+E8ij9bOOC0_s_2b0eZEvDA@mail.gmail.com> <4E848D45.5000001@redhat.com> <CABYV9SXaJJT6urtc3RpOLfqNiCe_SAfht=1CESJpQgtgtY4Xmw@mail.gmail.com> <4E86080A.7000009@redhat.com> <CABYV9SUgjeeD58LqELHr38GGvwZUcEndXqxdoR5xM_gtaUC1Kg@mail.gmail.com> <4E863399.6020803@redhat.com> <CABYV9SUt+mFr3XQLHnzJevBmovkop92tSRDnR9j4U7bOuDWuew@mail.gmail.com> <CABYV9SWznzBp=bTpeNJuP-ThP-b_wOGQuvV-9V7-NJoZ_9LFUA@mail.gmail.com> <4E89D11A.1020707@redhat.com> <CABYV9SV3ErQr=dE0tRTN+M__NiX7YLzE+c6XEhu-eHU8SaNr4Q@mail.gmail.com> <4E8D884A.7040405@gjlay.de> <CAFiYyc0VDJ-_+nJ8+WGiNYWmdQYHk7=3PCDp0w4NT=17SY5=3w@mail.gmail.com> <4E8D8B07.30209@gjlay.de>
On Thu, Oct 6, 2011 at 1:03 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
> Richard Guenther schrieb:
>> On Thu, Oct 6, 2011 at 12:51 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
>>> Artem Shinkarov schrieb:
>>>> Hi, Richard
>>>>
>>>> There is a problem with the testcases of the patch you have committed
>>>> for me. The code in every test-case is doubled. Could you please,
>>>> apply the following patch, otherwise it would fail all the tests from
>>>> the vector-shuffle-patch would fail.
>>>>
>>>> Also, if it is possible, could you change my name from in the
>>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last
>>>> version is the way I am spelled in the passport, and the name I use in
>>>> the ChangeLog.
>>>>
>>>> Thanks,
>>>> Artem.
>>>>
>>>> On Mon, Oct 3, 2011 at 4:13 PM, Richard Henderson <rth@redhat.com> wrote:
>>>>> On 10/03/2011 05:14 AM, Artem Shinkarov wrote:
>>>>>> Hi, can anyone commit it please?
>>>>>>
>>>>>> Richard?
>>>>>> Or may be Richard?
>>>>> Committed.
>>>>>
>>>>> r~
>>>>>
>>>> Hi, Richard
>>>>
>>>> There is a problem with the testcases of the patch you have committed
>>>> for me. The code in every test-case is doubled. Could you please,
>>>> apply the following patch, otherwise it would fail all the tests from
>>>> the vector-shuffle-patch would fail.
>>>>
>>>> Also, if it is possible, could you change my name from in the
>>>> ChangeLog from "Artem Shinkarov" to "Artjoms Sinkarovs". The last
>>>> version is the way I am spelled in the passport, and the name I use in
>>>> the ChangeLog.
>>>>
>>>>
>>>> Thanks,
>>>> Artem.
>>>>
>>> The following test cases cause FAILs because main cannot be found by the linker
>>> ?because if __SIZEOF_INT__ != 4 you are trying to compile and run an empty file.
>>>
>>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c
>>>> Index: gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c
>>> The following patch avoids __SIZEOF_INT__.
>>>
>>> Ok by some maintainer to commit?
>>
>> On a general note, if you need to add .x files, consider moving the
>> test to gcc.dg/torture instead.
>
> So should I move all vect-shuffle-*.c files so that they are kept together?
Yes.
> Johann
>
>> Richard.
>>
>>> Johann
>>>
>>> testsuite/
>>> ? ? ? ?* lib/target-supports.exp (check_effective_target_int32): New
>>> ? ? ? ?function.
>>> ? ? ? ?* gcc.c-torture/execute/vect-shuffle-1.c: Don't use
>>> ? ? ? ?__SIZEOF_INT__.
>>> ? ? ? ?* gcc.c-torture/execute/vect-shuffle-5.c: Ditto.
>>> ? ? ? ?* gcc.c-torture/execute/vect-shuffle-1.x: New file.
>>> ? ? ? ?* gcc.c-torture/execute/vect-shuffle-5.x: New file.
>