This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch,AVR]: Clean-up some SP insns

From: Georg-Johann Lay <avr at gjlay dot de>
To: Richard Henderson <rth at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, Denis Chertykov <chertykov at gmail dot com>, Eric Weddington <eric dot weddington at atmel dot com>
Date: Tue, 27 Sep 2011 21:20:42 +0200
Subject: Re: [Patch,AVR]: Clean-up some SP insns
References: <4E8181C2.5000706@gjlay.de> <4E81F0D4.5090909@redhat.com>

Richard Henderson schrieb:

On 09/27/2011 12:56 AM, Georg-Johann Lay wrote:
	* config/avr/avr-protos.h (avr_out_addto_sp): New prototype.
	* config/avr/avr.c (avr_out_addto_sp): New function.
	(adjust_insn_length): Handle ADJUST_LEN_ADDTO_SP.
	* config/avr/avr.md (adjust_len): Add "addto_sp".
	(*movhi_sp): Remove insn.
	(*addhi3_sp_R_pc2, *addhi3_sp_R_pc3): Merge to *addhi3_sp_R.
While this is a good cleanup by itself, and probably should be applied by itself, I think a good followup would be to merge the addhi3_sp_R pattern with the normal addhi3 pattern.
This should be fairly easy, given that both are handled via C
functions now.

There is bit more work for *addhi3 (PR50447) and thus adapting prologue/epilogue functions etc. Didn't do that yet.

Johann

r~

References:
- [Patch,AVR]: Clean-up some SP insns
  - From: Georg-Johann Lay
- Re: [Patch,AVR]: Clean-up some SP insns
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]