This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Mingw-users] [patch] --enable-dynamic-string default for mingw-w64


On 09/23/2011 03:59 PM, Paolo Carlini wrote:
On 09/23/2011 03:46 PM, Paolo Carlini wrote:
On 09/23/2011 11:39 AM, JonY wrote:
Ping, any updates?
I'm wondering if it wouldn't be cleaner to handle this in the appropriate config/os/ headers, something like (with a good comment before!):

#ifndef _GLIBCXX_FULLY_DYNAMIC_STRING
#define _GLIBCXX_FULLY_DYNAMIC_STRING
#endif
Even better would be changing the current infrastructure for this to have a default (not fully dynamic) of zero, a set value of one, undefined otherwise.
I hope you got the basic point anyway, sorry about the confusion ;)

I meant that if the user configuring doesn't pass anything to configure, then _GLIBCXX_FULLY_DYNAMIC_STRING remains undefined. Otherwise, zero is set in the acinclude.m4 procedure for no fully dynamic string and one for fully dynamic string. Then we have

#ifndef _GLIBCXX_FULLY_DYNAMIC_STRING
#define _GLIBCXX_FULLY_DYNAMIC_STRING 1
#endif

in the mingw config/os (with a good comment before!) and, in the basic_string.* headers we use:

#if _GLIBCXX_FULLY_DYNAMIC_STRING == 1

This is a standard pattern in configuries, anyway...

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]