This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros


On 07/16/2011 10:37 AM, Dodji Seketeli wrote:
+ location_t here = c_parser_peek_token (parser)->location;

Perhaps "first_token_loc"? It's unfortunate that we don't retain the locations of the individual declspecs, but I don't expect you to fix that.


+           SYNTAX_ERROR2_AT (prev_virtual_location,
+                             "missing binary operator before token \"%s\"",
+                             cpp_token_as_text (pfile, op.token));

It seems to me that the "missing X before" errors should point to the current token, not the previous one. So you can drop prev_virtual_location.


Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]