This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][Master] Finish function using absolute value not #define value
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Sep 2011 06:55:28 -0700
- Subject: Re: [Patch][Master] Finish function using absolute value not #define value
- References: <2950715866004049A240A2F9BB410E7315F244F6AE@azsmsx502.amr.corp.intel.com>
On Thu, Sep 8, 2011 at 9:38 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Hello Everyone,
> ? ? ? ?In several places, I found that finish_function was using an absolute integer as input parameter instead of these #defines
>
> #define SF_DEFAULT ? ? ? ? ? 0 ?/* No flags. ?*/
> #define SF_PRE_PARSED ? ? ? ?1 ?/* The function declaration has
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? already been parsed. ?*/
> #define SF_INCLASS_INLINE ? ?2 ?/* The function is an inline, defined
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? in the class body. ?*/
>
> I have attached a patch that should fix this (for example, use SF_DEFAULT instead of '0'). It should fix the bug #47791 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47791)
>
A few comments:
1. Remove [Master] in your email subject.
2. Put ChangeLog entries like:
http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00615.html
since you are not the only one who is changing trunk. Your
inlined ChangeLog won't apply when ChangeLogs are
updated by other people.
--
H.J.