This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script


On Tue, Sep 6, 2011 at 8:01 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
> Sure! Here is the fixed patch.

It won't apply.  Please make sure that it is against cilkplus branch.

H.J.
> Thanks,
>
> Balaji V. Iyer.
>
> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Tuesday, September 06, 2011 10:57 AM
> To: Iyer, Balaji V
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to testsuite script
>
> You should just say "* g++.dg/cilk-plus/cilk_plus.exp: Likewise" since the change is the same as above.
>
> H.J.
> On Tue, Sep 6, 2011 at 7:45 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>> I fixed all the changed you have requested. Here is an updated patch.
>>
>> Thanks,
>>
>> Balaji V. Iyer.
>>
>>
>> -----Original Message-----
>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>> Sent: Tuesday, September 06, 2011 10:41 AM
>> To: Iyer, Balaji V
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path to
>> testsuite script
>>
>> On Tue, Sep 6, 2011 at 7:30 AM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>> Attached, please find a patch with the modifications you have suggested (adding the info in Changelog.cilk).
>>
>> Please remove the extra blank line in ChangLog. ?ChangeLog should simply say what you did, not why.
>>
>> H.J.
>> ----
>>> Sorry for the mistake.
>>>
>>> Thanks,
>>>
>>> Balaji V. Iyer.
>>>
>>>
>>> -----Original Message-----
>>> From: H.J. Lu [mailto:hjl.tools@gmail.com]
>>> Sent: Tuesday, September 06, 2011 10:22 AM
>>> To: Iyer, Balaji V
>>> Cc: gcc-patches@gcc.gnu.org
>>> Subject: Re: [Patch][Cilkplus branch] Adding include directory path
>>> to testsuite script
>>>
>>> On Mon, Sep 5, 2011 at 9:52 PM, Iyer, Balaji V <balaji.v.iyer@intel.com> wrote:
>>>> Hello Everyone,
>>>> ? ? ? ?This patch is for the Cilk Plus branch. It will add the include directory path it the testsuite script (cilk_plus.exp) in both gcc.dg/cilk-plus and g++.dg/cilk-plus directories.
>>>>
>>>> Thanking You,
>>>>
>>>
>>> ChangeLog entries are missing.
>>>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]