This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Ada bootstrap failure


On Fri, Sep 2, 2011 at 6:55 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> And this is the real fix. ?Richard, do you want me to apply (part of it)?

A varaint of the patch is ok,

> In fact I'd even propose to revert the fold_builtin_alloca_for_var part of
> your patch and apply mine entirely, as eliminating alloca (0) early looks a
> interesting simplification. ?What do you think?

I'm not sure we want to create a the replacement decl with DECL_SIZE zero
though, so I suppose instead of making sure align is BITS_PER_UNIT shouldn't
we make sure that size is at least 1?  I fear we might run into other odd
problems with zero-size autos.

Thus, a variant of the patch that re-enables handling of size zero allocas
but adjusts the size to be at least 1 is ok.

Other opinions?

Thanks,
Richard.

> --
> Eric Botcazou
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]