This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: CFT: [build] Move fp-bit support to toplevel libgcc
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Ian Lance Taylor <iant at google dot com>
- Date: Fri, 05 Aug 2011 11:40:17 +0200
- Subject: Re: CFT: [build] Move fp-bit support to toplevel libgcc
- References: <yddbowzv35g.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <Pine.LNX.4.64.1107211550510.11368@digraph.polyomino.org.uk> <yddwreumwun.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4E3B9028.8010905@gnu.org>
Paolo Bonzini <bonzini@gnu.org> writes:
> On 08/03/2011 03:46 PM, Rainer Orth wrote:
>>
>> Ok for mainline if they pass?
>
> I think the avr-lib.h and h8300-lib.h files should be modified to only
> define the constants when compiling fp-bit, because they pollute the
> namespace.
>
> Both avr and h8300 only use floats, so you can wrap them in #ifdef FLOAT.
I'll do it this way.
> Another possibility is to add another -D option, like IN_FPBIT, to the
> Makefile and wrap the headers with that one.
Since there are only two instances currently, I think we should go for a
more general solution only when we need it.
> Otherwise ok.
Given that the patch is based on the unwinder one, could you have a look
at that, too? While I could rebase this one and the soft-fp one if need
be, I'd like to avoid it if possible.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University