This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: CFT: [build] Move fp-bit support to toplevel libgcc


Paolo Bonzini <bonzini@gnu.org> writes:

> On 08/03/2011 03:46 PM, Rainer Orth wrote:
>>
>> Ok for mainline if they pass?
>
> I think the avr-lib.h and h8300-lib.h files should be modified to only
> define the constants when compiling fp-bit, because they pollute the
> namespace.
>
> Both avr and h8300 only use floats, so you can wrap them in #ifdef FLOAT.

I'll do it this way.

> Another possibility is to add another -D option, like IN_FPBIT, to the
> Makefile and wrap the headers with that one.

Since there are only two instances currently, I think we should go for a
more general solution only when we need it.

> Otherwise ok.

Given that the patch is based on the unwinder one, could you have a look
at that, too?  While I could rebase this one and the soft-fp one if need
be, I'd like to avoid it if possible.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]