This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google][patch] Put make_heap's declaration on a single line to work around inconsistent debug locations
- From: Jeffrey Yasskin <jyasskin at google dot com>
- To: Ollie Wild <aaw at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Diego Novillo <dnovillo at google dot com>
- Date: Mon, 1 Aug 2011 20:38:15 -0700
- Subject: Re: [google][patch] Put make_heap's declaration on a single line to work around inconsistent debug locations
- References: <CANh-dXkn+mR2XGRZp_p=KQOkDuNeL3YY2br=YRaDhE95YFiHgA@mail.gmail.com> <CAFOgFcSG=Ztz2TEySYXWsxDP6mEniuO4D1jLUB7eL3wETzRHWA@mail.gmail.com>
And reverted in r177083 because I fixed the underlying problem.
On Fri, Jul 22, 2011 at 11:06 PM, Ollie Wild <aaw@google.com> wrote:
> Ok for inclusion in google/gcc-4_6.
>
> Ollie
>
> On Fri, Jul 22, 2011 at 5:46 PM, Jeffrey Yasskin <jyasskin@google.com> wrote:
>>
>> For the google/gcc-4_6 branch _only_. I'll fix the inconsistency in
>> debug locations later for trunk and google/main.
>>
>> In some translation units the debug location of make_heap is the
>> location of its name; in other TUs it's the location of the closing
>> ')'. This causes false positives in gold's ODR checker. Until I can
>> find why the locations are inconsistent, we can work around the
>> problem by putting the name and closing ')' on the same line.
>>
>> libstdc++-v3/ChangeLog
>> 2011-07-22 ? Jeffrey Yasskin ?<jyasskin@google.com>
>>
>> ? ? ? ?* include/bits/stl_heap.h(make_heap): Remove a newline.
>