This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [build, ada] Allow Solaris bootstrap with C++ (PR bootstrap/49794)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Ian Lance Taylor <iant at google dot com>, Tom Tromey <tromey at redhat dot com>, Arnaud Charlet <charlet at adacore dot com>
- Date: Mon, 25 Jul 2011 19:00:00 +0200
- Subject: Re: [build, ada] Allow Solaris bootstrap with C++ (PR bootstrap/49794)
- References: <yddbowonc44.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <CAHFMJ7s=jvAoh3CGaxR6V1cz9vkO9Xv-dYQqYm20W3py44Ao3A@mail.gmail.com>
Paolo,
> On Wed, Jul 20, 2011 at 18:35, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>> ?I've hacked around this by wrapping the AM_ICONV calls in
>> ?AC_LANG_{PUSH, POP}(C++), but I think this exposes a fundamental
>> ?issue: the configure tests must be performed with the compiler used
>> ?for the build. ?That this works without is pure luck IMO.
>
> Right, but it also applies to more than this test. If you wrapped in
> ifs more than just this call, the approach may be fine, but first I
> would like to look at Autoconf (or at the diff for the regenerated
> configure) to check that what you're doing is safe. I'm afraid it may
the configure diff looked completely innocent to me, but that may be
just me ;-(
> not be, which means you're patch is not good for the configure part.
> :(
Sorry, I only say your mail after the weekend, and have already checked
in the patch based on Ian's approval. At least so far I've not become
aware of any problems caused by the patch.
>> * Also, the definition of HAVE_DESIGNATED_INITIALIZERS was wrong for g++
>> ?on Solaris which again defines __STDC_VERSION__ 199901L. ?To fix this,
>> ?I never define H_D_I if __cplusplus.
>
> Is this a valid definition of __STDC_VERSION__ at all?
Why wouldn't it be? It's the standard C99 value.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University