This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH (8/7)] Fix a bug in multiply-and-accumulate
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Andrew Stubbs <ams at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 18 Jul 2011 16:46:38 +0200
- Subject: Re: [PATCH (8/7)] Fix a bug in multiply-and-accumulate
- References: <4E034EF2.3070503@codesourcery.com> <4E24319D.3040607@codesourcery.com>
On Mon, Jul 18, 2011 at 3:14 PM, Andrew Stubbs <ams@codesourcery.com> wrote:
> As far as I can tell, the patch series so far works great as long as the
> input type of the accumulate value is the same as the output type.
> Unfortunately you get an ICE otherwise .... doh!
>
> This patch should fix the problem.
>
> I could have inserted this fix into the correct spot in the existing series,
> but I've already regenerated the whole lot several times, it's getting
> confusing, and they're all approved already, so I'm just going to tack this
> one on the end.
Will signedness be always the same? Usually the canonical check to
use would be !useless_type_conversion_p (type, TREE_TYPE (add_rhs)).
Ok if you use that.
Thanks,
Richard.
> Andrew
>