This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Correct fix for scheduler bug PR11320
- From: Bernd Schmidt <bernds at codesourcery dot com>
- To: Andrey Belevantsev <abel at ispras dot ru>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Eric Botcazou <ebotcazou at adacore dot com>, Steve Ellcey <sje at cup dot hp dot com>, "Vladimir N. Makarov" <vmakarov at redhat dot com>
- Date: Thu, 14 Jul 2011 13:22:46 +0200
- Subject: Re: Correct fix for scheduler bug PR11320
- References: <4E1EBEFE.3080002@codesourcery.com> <4E1ED106.6030600@ispras.ru>
On 07/14/11 13:20, Andrey Belevantsev wrote:
> Hello Bernd,
>
> FWIW, we have discussed your change with Alexander and we think you are
> right about the scheduler changes. One question is:
>
> On 14.07.2011 14:03, Bernd Schmidt wrote:
>> --- gcc/sched-deps.c (revision 176195)
>> +++ gcc/sched-deps.c (working copy)
>> @@ -568,7 +568,7 @@
>> (rev1==rev2
>> ? reversed_comparison_code (cond2, NULL)
>> : GET_CODE (cond2))
>> - && XEXP (cond1, 0) == XEXP (cond2, 0)
>> + && rtx_equal_p (XEXP (cond1, 0), XEXP (cond2, 0))
>> && XEXP (cond1, 1) == XEXP (cond2, 1))
>> return 1;
>> return 0;
>
> this hunk from conditions_mutex_p seems to be unrelated?
Oh yes, sorry about that. That was approved a while ago and I haven't
gotten around to checking it in.
Bernd