This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Mikael Morin <mikael dot morin at sfr dot fr>, fortran at gcc dot gnu dot org, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 8 Jul 2011 23:14:16 +0300
- Subject: Re: [Patch, Fortran] Add stat=/errmsg= support to _gfortran_caf_register
- References: <4E15458B.8050901@net-b.de> <201107071335.34176.mikael.morin@sfr.fr> <4E15AB34.80105@net-b.de>
On Thu, Jul 7, 2011 at 15:48, Tobias Burnus <burnus@net-b.de> wrote:
> I have now committed the patch with only the nits fixed (Rev.175966). But
> given that the coarray support - especially with regards to the library - is
> still in a flux, we can still change everything, including the ABI of the
> library and the file organization. I am sure that not all design decisions
> are optimal.
One minor thing is that one should use gfc_charlen_type_node
(frontend) and gfc_charlen_type (library) for string lengths instead
of int. (Currently gfc_charlen_type is a typedef for int, but if this
is at some point changed to size_t, as has been discussed, then it's
easier if one needs only to change a few places.)
--
Janne Blomqvist