This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [pph] Stream and restore static_aggregates (issue4626096)

From: Diego Novillo <dnovillo at google dot com>
To: Gabriel Charette <gchare at google dot com>
Cc: reply at codereview dot appspotmail dot com, crowl at google dot com, gcc-patches at gcc dot gnu dot org
Date: Wed, 06 Jul 2011 14:27:31 -0400
Subject: Re: [pph] Stream and restore static_aggregates (issue4626096)
References: <20110706040822.573AA1DA1D1@topo.tor.corp.google.com> <CAJTZ7LK_xkEj_gCAa6sL=H1-TRAysVqPgK3ov=NymhWzjy7uLQ@mail.gmail.com>

On 11-07-06 13:12 , Gabriel Charette wrote:

I had removed these two lines because that pretty much does nothing (I
think, at least removing them didn't make anything fail...)... When we

It started causing an ICE in the test case that I marked fixed and others (because we now stream static_aggregates).

Otherwise I agree we will need to modify
pph_add_bindings_to_namespace. It is still missing the merge of
"usings" and "using_directives". "static_decls" if I remember
correctly were automatically reinserted when doing
pushdecl_into_namespace for the static decls in "names".

Yeah. Jason suggests merging scope_chain->bindings read from the PPH image into scope_chain->bindings from the translation unit. I've started down that road. More later.

Diego.

References:
- [pph] Stream and restore static_aggregates (issue4626096)
  - From: Diego Novillo
- Re: [pph] Stream and restore static_aggregates (issue4626096)
  - From: Gabriel Charette

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]