This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping #1: [Patch, AVR, 4.6+trunk]: PR44643 addendum
- From: Denis Chertykov <chertykov at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Eric Weddington <eric dot weddington at atmel dot com>, Anatoly Sokolov <aesok at post dot ru>
- Date: Mon, 4 Jul 2011 16:10:54 +0400
- Subject: Re: Ping #1: [Patch, AVR, 4.6+trunk]: PR44643 addendum
- References: <4E0C438A.8010604@gjlay.de> <4E119344.7050803@gjlay.de>
2011/7/4 Georg-Johann Lay <avr@gjlay.de>:
> Georg-Johann Lay wrote:
>
> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02318.html
>
>> avr_insert_attributes uses TREE_READONLY on get readonlyness of node.
>>
>> That does not work for C++ arrays: it gives false error
>> "variable must be const in order to be put into read-only section by
>> means of '__attribute__((progmem))'".
>>
>> This patch peels arrays and uses TYPE_READONLY.
>>
>> I did not open separate PR for this, tagged it as addendum to PR44643
>> instead.
>>
>> Lightly tested on own code. There is no 'progmem' in testsuite, so
>> from testsuite's perspective that code is dead, anyway...
>>
>> Johann
>>
>> Â Â Â PR target/44643
>> Â Â Â * config/avr/avr.c (avr_insert_attributes): Use TYPE_READONLY
>> Â Â Â instead of TREE_READONLY.
Approved.
Denis.