This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] Test cleanup (issue4572050)
- From: Lawrence Crowl <crowl at google dot com>
- To: Gabriel Charette <gchare at google dot com>
- Cc: reply at codereview dot appspotmail dot com, dnovillo at google dot com, gcc-patches at gcc dot gnu dot org
- Date: Fri, 1 Jul 2011 17:51:41 -0700
- Subject: Re: [pph] Test cleanup (issue4572050)
- References: <20110608204447.BCB5422265C@jade.mtv.corp.google.com> <CAJTZ7LKGZEJC_vbSX9ZSLkDG1kqJdHjhZzM2UDZUUrZxc-93AQ@mail.gmail.com>
On 7/1/11, Gabriel Charette <gchare@google.com> wrote:
> One problem now though: `// pph asm xdiff`, only flags for asm diffs,
> but those could be different diffs after a change (for the better or
> worse) and this won't be caught. It's probably hard to get something
> precise on this, but maybe we could simply add the # of lines of diff
> expected, e.g. `// pph asm xdiff 32`. Then we XFAIL if the number of
> expected lines in the diff match, but actually fail if the number of
> lines in the diff is now different.
>
> I'm not very familiar with dg.. Is that doable? Would be very helpful
> at this stage.
That looks easy enough. I need to finish the current test stuff
before I get to that though.
--
Lawrence Crowl