This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: Richard Henderson <rth at redhat dot com>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org, Jakub Jelinek <jakub at redhat dot com>
- Date: Fri, 1 Jul 2011 06:42:04 -0700
- Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
- References: <20110625161357.GA5401@intel.com> <4E078E58.20903@redhat.com> <BANLkTikToedVDqx9V+bB9xb+dL_r-6f31g@mail.gmail.com> <4E07A879.70509@redhat.com> <BANLkTik8ZOfWVUV7SV1ryQ=yJtUiCG+tqQ@mail.gmail.com> <4E089A88.60401@redhat.com> <BANLkTimw8O0UnnVATPKgrRCVT=82sO48Dw@mail.gmail.com> <4E0C8361.5050403@redhat.com> <BANLkTinOGKQCq2abZW0L7CLOQ901+Oodxg@mail.gmail.com> <4E0C904E.8090504@redhat.com> <BANLkTiknF6h_qJ9rAgBikdAM8O7RgSdyHA@mail.gmail.com> <BANLkTimGtPskWYsGOi+hp59DKnDW7wD2sw@mail.gmail.com> <BANLkTimYZoGBBUxq+uMehqGxR5E1cpEavA@mail.gmail.com> <yddvcvnxkm0.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTikRuXz1RP1LxU8BCEFoT+pNP5e_Jw@mail.gmail.com> <yddr56bxkb1.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTimRWq4S4bKQpvuYzO3Go6yMc2fcgg@mail.gmail.com> <4E0CC85E.3090401@redhat.com> <BANLkTimt9V4kyKE2jmixeMOW=k7ghWrw+A@mail.gmail.com> <yddaacyxtjd.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <BANLkTi=1Y8wHj6Y_vMp5GJSp-C+yNVa5dw@mail.gmail.com> <yddvcvmrujf.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Fri, Jul 1, 2011 at 6:37 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> On Fri, Jul 1, 2011 at 2:02 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>>
>>>> Here is the updated patch. ?It works on simple tests.
>>>> I am running full tests. ?I kept config/i386/value-unwind.h
>>>> since libgcc/md-unwind-support.h is included too late
>>>> in unwind-dw2.c and I don't want to move it to be on
>>>> the safe side.
>>>
>>> Oh please, don't pile hack upon hack to avoid proper testing.
>>>
>>
>> What is your suggestion?
>
> How about moving the md-unwind-support.h include up to the rest of the
> includes? ?The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
> and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
> helper macro, so order shouldn't matter.
>
It doesn't work on Linux/x86-64:
In file included from
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:39:0:
./md-unwind-support.h: In function \u2018x86_fallback_frame_state\u2019:
./md-unwind-support.h:121:30: error: dereferencing pointer to incomplete type
./md-unwind-support.h:129:17: error: dereferencing pointer to incomplete type
./md-unwind-support.h:141:23: error: dereferencing pointer to incomplete type
./md-unwind-support.h:153:49: error: dereferencing pointer to incomplete type
./md-unwind-support.h: In function \u2018x86_frob_update_context\u2019:
./md-unwind-support.h:185:30: error: dereferencing pointer to incomplete type
./md-unwind-support.h:192:5: warning: implicit declaration of function
\u2018_Unwind_SetSignalFrame\u2019 [-Wimplicit-function-declaration]
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c: At top level:
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:140:1: warning:
conflicting types for \u2018_Unwind_SetSignalFrame\u2019 [enabled by
default]
/export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:140:1: error:
static declaration of \u2018_Unwind_SetSignalFrame\u2019 follows
non-static declaration
./md-unwind-support.h:192:5: note: previous implicit declaration of
\u2018_Unwind_SetSignalFrame\u2019 was here
--
H.J.