This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Rename attribs.c to attributes.c
On Wed, 22 Jun 2011, Nicola Pero wrote:
> > Huh, I see no reason for this rename. It'll just make patches across
> > releases harder.
>
> Sure. But any change will make "patches across releases harder" ... does
> it mean we can't make any changes - not even in phase 1 ? :-(
I think moving files only makes sense where it makes the modular structure
clearer - for example, the past move of C-family code to the c-family/
directory, or moving libgcc sources to the toplevel libgcc/ directory, or
moving common code (see
<http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01779.html> for my remarks
on what to consider common) to the common/ directory.
That your patch needed to change so many places does show up a confusion
about what sort of an object attribs.o is; it looks like it should go in
the main OBJS list in Makefile.in and not in any of the other lists it's
presently in.
--
Joseph S. Myers
joseph@codesourcery.com