This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] c-pragma: adding a data field to pragma_handler
On Fri, 10 Jun 2011, Pierre Vittet wrote:
> I guess this is better now.
>
> Changelog (gcc/c-family):
>
> 2011-06-10 Pierre Vittet <piervit@pvittet.com>
>
> * c-pragma.h (pragma_handler_1arg, pragma_handler_2arg): New handler.
> (gen_pragma_handler): New union.
> (internal_pragma_handler): New type.
> (c_register_pragma_with_data,
> c_register_pragma_with_expansion_and_data): New functions.
> * c-pragma.c (registered_pragmas, c_register_pragma_1,
> c_register_pragma, c_register_pragma_with_expansion,
> c_invoke_pragma_handler): Changed to work with internal_pragma_handler.
> (c_register_pragma_with_data,
> c_register_pragma_with_expansion_and_data): New functions.
Thanks. The c-family changes are OK if you remove the last patch hunk in
c-pragma.c (which just reformats existing code); that hunk is OK as a
separate commit with its own ChangeLog entry, since lines shouldn't be
wider than 80 columns. The testsuite changes will need to be approved by
a plugin maintainer (or a global reviewer) if they haven't already been so
approved.
--
Joseph S. Myers
joseph@codesourcery.com