This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google][RFA] add extra text to stack frame warnings (issue4479046)
- From: Chris Demetriou <cgd at google dot com>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: Diego Novillo <dnovillo at google dot com>, reply at codereview dot appspotmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 Jun 2011 23:50:04 -0700
- Subject: Re: [google][RFA] add extra text to stack frame warnings (issue4479046)
- References: <20110505182734.5CC6A1E819C@cgda.mtv.corp.google.com> <BANLkTin+Z247+w9qmie0PzzVCZSOueMk0w@mail.gmail.com> <BANLkTin7bURWJG7+NajxJMi6YwXjK_xxFQ@mail.gmail.com> <BANLkTi=x=x6epKSrJAH=6ZgQGB4v8Cudbw@mail.gmail.com> <BANLkTikpVsjzGht6whLyxBSGi6ADbyTH8g@mail.gmail.com> <BANLkTimMdjRDwC7Z-xsAbV4GdJn8gP+QgA@mail.gmail.com>
[resending plain text. Sorry for the noise.]
[sorry, i got stuck doing a bunch of other things.]
On Fri, May 6, 2011 at 10:05, Andrew Pinski <pinskia@gmail.com> wrote:
>
> On Fri, May 6, 2011 at 1:52 AM, Chris Demetriou <cgd@google.com> wrote:
> > In theory, a more general warning-text-addition mechanism could be useful.
> > e.g. a flag that said "when outputting a warning about flag 'foo',
> > output this additional text" could be useful.
> > However, we haven't felt the need to do this for other warnings.
> >
> > IMO, a general solution along these lines would be solving a problem
> > that ~nobody has. ?8-)
>
> We already output the option which enables the warning that seems like
> a general solution.
Yeah. ?I was going to look into using something similar to implement a
generic text-addition mechanism for warnings... but got stuck in
previously-mentioned bunch of other things. ?8-(
I ran out of time, ended up checking this in as-is (after updating the
changelog date and retesting).
I may get back to doing it the better way... but it won't be for a while.
chris