This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [pph] Removing pth implementation from pph implementation (issue4571047)
- From: Diego Novillo <dnovillo at google dot com>
- To: Gabriel Charette <gchare at google dot com>
- Cc: reply at codereview dot appspotmail dot com, Lawrence Crowl <crowl at google dot com>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 6 Jun 2011 18:14:27 -0400
- Subject: Re: [pph] Removing pth implementation from pph implementation (issue4571047)
- References: <20110606220830.AB7591C37DF@gchare.mtv.corp.google.com>
On Mon, Jun 6, 2011 at 18:08, Gabriel Charette <gchare@google.com> wrote:
> Removed all of the pth code with the exception of pth_save_token_cache
> and pth_load_token_cache and their respective closure.
>
> The renaming of the remaining functions to pph will be done in a separate patch.
>
> The patch was tested with a full bootstrap build and regression testing.
>
> Note: There might be header files that are now unused due to the code removed.
>
> 2011-06-06 ÂGabriel Charette Â<gchare@google.com>
>
> Â Â Â Â* gcc/c-family/c.opt (fpth): Remove. Update all users.
> Â Â Â Â(fpth-debug): Likewise.
> Â Â Â Â(fpth-stats). Likewise.
> Â Â Â Â(fpth-md5). Likewise.
> Â Â Â Â* gcc/cp/pph.c (pth_stats): Remove field. Update all users.
> Â Â Â Â(pth_get_state): Remove. Update all users.
> Â Â Â Â(pth_debug_identifiers): Likewise.
> Â Â Â Â(pth_debug_token_hunks): Likewise.
> Â Â Â Â(pth_debug_state): Likewise.
> Â Â Â Â(pth_image_lookup): Likewise.
> Â Â Â Â(pth_init): Likewise.
> Â Â Â Â(pth_print_stats): Likewise.
> Â Â Â Â(pth_finish): Likewise.
> Â Â Â Â* gcc/cp/pph.h (struct pth_include): Likewise.
> Â Â Â Â(struct pth_image): Likewise.
> Â Â Â Â(struct pth_state): Likewise.
> Â Â Â Â(PTH_STATS_INCR): Likewise.
> Â Â Â Â* gcc/timevar.def (TV_PTH_DEPENDENCY): Likewise.
> Â Â Â Â(TV_PTH_MANAGE): Likewise.
> Â Â Â Â(TV_PTH_MD5): Likewise.
> Â Â Â Â(TV_PTH_LOAD): Likewise.
> Â Â Â Â(TV_PTH_SAVE): Likewise.
> Â Â Â Â(TV_PTH_SKIP_TOKENS): Likewise.
> Â Â Â Â(TV_PTH_INIT): Likewise.
You also need to remove all the pth support in the testsuite. You'd
be getting tons of errors from pth.exp. Essentially, everything in
gcc/testsuite/* that references pth can go. This includes
gcc/testsuite/lib/dg-pth.exp, gcc/testsuite/g++.dg/pth/* and also
you'll have to edit gcc/testsuite/g++.dg/dg.exp to remove the code
that tries to execute pth.exp.
OK with that change.
Diego.