This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google] Disable getpagesize() for Android toolchain (issue4515131)
Actually I don't know why in gcc-4.6 libiberty is built for target
when --disable-stdc++-v3 is given. Is libiberty used by other target
libraries now? If not, we can skip libiberty for general Android
toolchain.
But, I still think it would be nice to make libiberty work, in case it
is needed in some cases.
Jing
On Wed, May 25, 2011 at 5:25 PM, Doug Kwan (Ãö®¶¼w) <dougkwan@google.com> wrote:
> Jing
>
> Can't we just skip libiberty in top-level configure.ac? Look for the
> comment "Disable target libiberty for some systems."
>
> -Doug
>
> On Wed, May 25, 2011 at 5:17 PM, Jing Yu <jingyu@google.com> wrote:
>> Hi Joseph,
>>
>> We notice that gcc starts to build libiberty for target as a multilib
>> since gcc-4.6, even if we give --disable-stdc++-v3.
>> Since then, we run into the incompatible getpagesize() error.
>>
>> I am wondering how to disable build of libiberty for target? I
>> searched mailing list. One guy said --disable-libiberty controls the
>> host libiberty, not the target one, another guy said the option
>> controls both host and target builds.
>>
>> In some environment we still need to build libstdc++ libraries, where
>> libiberty has to be built for target. Can we use #ifndef __ANDROID__
>> to wrap around the getpagesize() definition? It is working for us.
>>
>> Thanks,
>> Jing
>>
>>
>> On Tue, May 24, 2011 at 11:07 AM, Doug Kwan (Ãö®¶¼w) <dougkwan@google.com> wrote:
>>> Shouldn't we test
>>>
>>> ifndef __ANDROID__
>>>
>>> instead?
>>>
>>> -Doug
>>>
>>> On Tue, May 24, 2011 at 2:39 AM, Guozhi Wei <carrot@google.com> wrote:
>>>> Hi
>>>>
>>>> This patch is for google/main.
>>>>
>>>> In order to be compatible with current bionic and sysroot, we need to disable
>>>> getpagesize(). After getpagesize() in bionic is changed and ndk contains that
>>>> change, we can reenable it.
>>>>
>>>> Jing can give more details about it.
>>>>
>>>> This patch has been tested on arm qemu without regression.
>>>>
>>>> thanks
>>>> Carrot
>>>>
>>>> 2011-05-24 Jing Yu <jingyu@google.com>
>>>>
>>>> * ChangeLog.google-main: New file.
>>>> * getpagesize.c(getpagesize): Disable it for bionic.
>>>>
>>>>
>>>> Index: ChangeLog.google-main
>>>> ===================================================================
>>>> --- ChangeLog.google-main (revision 0)
>>>> +++ ChangeLog.google-main (revision 0)
>>>> @@ -0,0 +1,5 @@
>>>> +Copyright (C) 2011 Free Software Foundation, Inc.
>>>> +
>>>> +Copying and distribution of this file, with or without modification,
>>>> +are permitted in any medium without royalty provided the copyright
>>>> +notice and this notice are preserved.
>>>> Index: getpagesize.c
>>>> ===================================================================
>>>> --- getpagesize.c (revision 174099)
>>>> +++ getpagesize.c (working copy)
>>>> @@ -60,11 +60,13 @@ BUGS
>>>> # endif /* PAGESIZE */
>>>> #endif /* GNU_OUR_PAGESIZE */
>>>>
>>>> +#if DEFAULT_LIBC != LIBC_BIONIC
>>>> int
>>>> getpagesize (void)
>>>> {
>>>> return (GNU_OUR_PAGESIZE);
>>>> }
>>>> +#endif
>>>>
>>>> #else /* VMS */
>>>>
>>>>
>>>> --
>>>> This patch is available for review at http://codereview.appspot.com/4515131
>>>>
>>>
>>
>