RE: CR16 Port addition

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Fri, 20 May 2011, Sumanth Gundapaneni wrote:

> > There is no such target as target-mudflap,
> The configure file is altered as per your suggestion.

Please remove the remaining toplevel configure changes from the patch.

I moved the code disabling libgcj for particular targets out of the 
general case over targets, into a separate case statement - and removed 
most of it by simply disabling Java for targets without a libffi port.  
You don't have a libffi port, so Java is automatically disabled.  With my 
toplevel cleanups, it's a lot less likely that a new port is going to need 
toplevel configure changes at all.

If you want to enable GDB for some targets but not others, that's not a 
matter for a GCC-port patch; such a toplevel change would best be sent in 
the context of a GDB port submission.  Because port submissions are large 
patches, it's always good to split out separable pieces like that anyway.

> >The libstdc++-v3 changes also seem suspicious.  
> The configure files of libstdc++-v3 are changed as advised.  

Now you seem to have a stray change to the generated file 
libstdc++-v3/configure, with no corresponding source file change.  That's 
always wrong; such files should only ever be changes by regeneration from 
the corresponding sources.  Again, you can probably just eliminate this 
change and make the patch smaller.

> >I'm still not satisfied with the forked version of the unwind code.  
> >Please show a diff of what the minimum changes would be to the 
> I have attached diff file (unwind.diff) for your reference. Please
> go through it. As explicated before the CR16's programming memory 

I said "a diff of what the minimum changes would be to the 
target-independent unwind-dw2-* files for CR16 to work with those files 
based on behavior in those files being conditioned as needed on target 
macros defined by CR16", not a raw diff between two files, but the changes 
appear small enough that it certainly looks like you should be able to 
define a few target macros (in a file in libgcc/config/cr16 listed in 
libgcc_tm_file) and make the code in unwind-dw2-* use those macros, 
instead of having separate copies of the files.


Since you first submitted the port, a file contrib/config-list.mk has been 
added to support all-targets builds, to help detect if a target stops 
building cleanly.  You should add the new target cr16-elf to this file.

-- 
Joseph S. Myers
joseph@codesourcery.com