This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: New GTY ((atomic)) option
On Thu, 19 May 2011 20:10:35 +0200 (CEST)
"Nicola Pero" <nicola.pero@meta-innovation.com> wrote:
> >> ? ? ? ?* gengtype.c (walk_type): Implemented "atomic" GTY option.
> >> ? ? ? ?* doc/gty.texi (GTY Options): Document "atomic" GTY option.
> >
> > The patch is OK, with difference between "skip" and "atomic" options
> > documented. (Can be done as a follow-up patch).
>
> Thanks for the quick review. Here's an updated patch with revised
> documentation.
>
> Ok to go ?
I have no power to approve that, but I find the patch quite nice.
However, did you check that the atomic qualifier is correctly written &
re-read in the state (I believe you did, otherwise it probably won't
work). This is needed for plugins using it, or using atomic qualified
fields of existing (or future) structures.
Regards
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***